Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle javascript with Jsbundling #3590

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Bundle javascript with Jsbundling #3590

merged 1 commit into from
Jan 18, 2024

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Oct 2, 2023 •
edited
Loading

Sprockets is not widely supported anymore. This provides parity with our other projects.

@jcoyne jcoyne force-pushed the jsbundling branch 4 times, most recently from f7cca90 to 99d91ab Compare October 2, 2023 22:30
@jcoyne jcoyne marked this pull request as ready for review October 16, 2023 18:32
@jcoyne jcoyne changed the title Jsbundling Bundle javascript with Jsbundling Oct 16, 2023
@jcoyne jcoyne force-pushed the jsbundling branch 2 times, most recently from e78021f to 83b1ced Compare October 23, 2023 12:17
mjgiarlo
mjgiarlo approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@mjgiarlo mjgiarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward to me, mostly mechanical changes. Approve pending confirmation that this has been tested in a deployed environment.

@jcoyne jcoyne merged commit 0b80d63 into main Jan 18, 2024
4 checks passed
@jcoyne jcoyne deleted the jsbundling branch January 18, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjgiarlo mjgiarlo mjgiarlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcoyne @mjgiarlo