Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure custom facet icons get the correct fill color #1405

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

thatbudakguy
Copy link
Member

@thatbudakguy thatbudakguy commented Sep 12, 2024

The "Other" option in the resource class facet is a local component,
so it was using a blue color instead of the standard gray. This
ensures that custom icon components get the right color.

Before

Screenshot 2024-09-12 at 10 41 47

After

Screenshot 2024-09-12 at 10 41 36

Verified

This commit was signed with the committer’s verified signature.
thatbudakguy Nick Budak
The "Other" option in the resource class facet is a local component,
so it was using a blue color instead of the standard gray. This
ensures that custom icon components get the right color.
@marlo-longley marlo-longley merged commit 376ffa3 into main Sep 12, 2024
2 checks passed
@marlo-longley marlo-longley deleted the facet-icon-fill branch September 12, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants