Switch to jsbundling-rails #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylor-steve
force-pushed
the
sct-jsbundling
branch
3 times, most recently
from
b9c9ab8 to
bc76afa
Compare
taylor-steve
force-pushed
the
sct-jsbundling
branch
from
bc76afa to
fd707a7
Compare
We need the bundle for bloodhound. This is removed in Spotlight v5.
Easier than fighting all the rollup issues with different leaflet instances
Multiple rolled up bundles expecting external leaflet.
I'm too lazy to resolve this in the merge editor every time
Enable range limit JS
taylor-steve
force-pushed
the
sct-jsbundling
branch
from
3ec8153 to
63c4b85
Compare
corylown
reviewed
Feb 14, 2025
Gemfile
Outdated
| @@ -88,7 +88,7 @@ gem 'config' | |||
| gem 'bootstrap', '~> 5.3' | |||
| gem 'bootstrap_form', '~> 5.4' | |||
| gem 'blacklight', '~> 8.0' | |||
| gem 'blacklight-gallery', '~> 4.4' | |||
| gem 'blacklight-gallery', '~> 4.8.4' | |||
There was a problem hiding this comment.
Can we set this to ~> 4.8 instead? This would allow an update to 4.9 while ~> 4.8.4 won't.
corylown
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch of #2787.
Switching to jsbundling-rails in anticipation of Spotlight v5.