Skip to content

Commit

Permalink
Merge pull request #1050 from sul-dlss/recalled-date
Browse files Browse the repository at this point in the history
Remove references to recalled_date; not tracked by FOLIO
  • Loading branch information
cbeer authored Feb 13, 2024
2 parents 04aa375 + e647255 commit 85ecdb7
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 11 deletions.
5 changes: 0 additions & 5 deletions app/models/folio/checkout.rb
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,6 @@ def checkout_date
Time.zone.parse(record['loanDate'])
end

def recalled_date
# TODO: unclear if FOLIO keeps this information
nil
end

def recalled?
record.dig('details', 'dueDateChangedByRecall') || record.dig('details', 'dueDateChangedByHold')
end
Expand Down
4 changes: 0 additions & 4 deletions app/views/checkouts/_checkout.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@
<dd class="col-8">
<%= today_with_time_or_date(checkout.checkout_date, short_term: checkout.short_term_loan?) %>
</dd>
<% if checkout.recalled_date %>
<dt class="col-3 offset-1 col-md-2 offset-md-2">Recalled:</dt>
<dd class="col-8"><%= l(checkout.recalled_date, format: :short) %></dd>
<% end %>
<% if checkout.overdue? %>
<dt class="col-3 offset-1 col-md-2 offset-md-2">Days overdue:</dt>
<dd class="col-8"><%= checkout.days_overdue %></dd>
Expand Down
1 change: 0 additions & 1 deletion app/views/checkouts/_checkout.json.jbuilder
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ json.attributes do
json.due_date checkout.due_date
json.days_overdue checkout.days_overdue
json.checkout_date checkout.checkout_date
json.recalled_date checkout.recalled_date
json.recalled? checkout.recalled?
json.claims_returned_date checkout.claims_returned_date
json.claimed_returned? checkout.claimed_returned?
Expand Down
1 change: 0 additions & 1 deletion spec/views/checkouts/_checkout.html.erb_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
overdue?: false,
patron_key: 'xyz321',
recalled?: false,
recalled_date: nil,
renewable?: false,
short_term_loan?: false,
sort_key: nil,
Expand Down

0 comments on commit 85ecdb7

Please sign in to comment.