Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Symphony references from RenewalsController comment #1043

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Remove Symphony references from RenewalsController comment #1043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions app/controllers/renewals_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,8 @@ def renew_item_params
params.require(%I[item_key])
end

# Make sure the checkout belongs to the user trying to do the renewal, and
# also make sure the item is not renewable for reasons that symphony doesn't
# know about (e.g. the itemCat5 hack we're doing during COVID-19 times; other
# conditions are handled by business logic in Symphony so we don't need to
# worry about being exhaustive here.)
# Make sure the checkout belongs to the user trying to do the renewal
# and make sure the item is renewable
def authorize_update!
checkout = patron_or_group.checkouts.find { |request| request.item_key == params.require(:item_key) }

Expand Down
Loading