Remove fee/fine conditions for proxy groups that do not apply in FOLIO #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corylown
force-pushed
the
group-fines-payments
branch
from
65fd9db to
3455dfd
Compare
jcoyne
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FOLIO fines on items borrowed by a proxy are associated with the sponsor's individual account. We never display these fines when the proxy views their group activity and the fines display on the "Self" tab for the sponsor. None of the conditions in the related fine/summary views that check for both fines and the group parameter being set will ever be true. These conditions existed for Symphony. We can now remove the conditionals and the Symphony-only displays.