Build DAG outline #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsu
approved these changes
Jun 19, 2024
| """ | ||
| snapshot_dir = create_snapshot_dir(data_dir) | ||
| return snapshot_dir | ||
|
|
||
| @task() | ||
| def fetch_sul_pub(snapshot_dir): | ||
| def dimensions_harvest_orcid(orcids): |
There was a problem hiding this comment.
I wonder if a name like dimensions_harvest_dois might better describe what is being harvested?
| return True | ||
|
|
||
| @task() | ||
| def openalex_harvest_orcid(orcids): |
There was a problem hiding this comment.
Same question here: does openalex_harvest_dois() describe what is being harvested?
| """ | ||
| return True | ||
|
|
||
| @task() | ||
| def fetch_openalex(dois): | ||
| def dimensions_harvest_doi(dois): |
There was a problem hiding this comment.
Here we are harvesting publications?
| """ | ||
| return True | ||
|
|
||
| @task() | ||
| def fetch_dimensions(dois): | ||
| def openalex_harvest_doi(dois): |
There was a problem hiding this comment.
We are harvesting publications instead of dois.
| @@ -70,16 +85,16 @@ def merge_publications(sul_pub, openalex, dimensions): | |||
| return True | |||
|
|
|||
| @task() | |||
| def merge_contributors(pubs): | |||
| def join_org_data(pubs, org_data): | |||
There was a problem hiding this comment.
I wonder if it might be better to refer to them as authors instead of org_data?
join_authors() ?
|
I'm merging this and will clean up the names in my next pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.