Paginate the Dimensions works response #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A batch size of 75 exceeds the page size of 50, which means 25 DOIs will not be returned unless pagination is used. This commit adds pagination with a page size of 200 (the max) and modifies the test to make sure that the pagination is happening.
edsu
commented
Jun 24, 2024
| @@ -0,0 +1,232 @@ | |||
| doi | |||
There was a problem hiding this comment.
These are DOIs that have metadata in OpenAlex.
edsu
commented
Jun 24, 2024
edsu
commented
Jun 24, 2024
|
|
||
| # look up the publication metadata for them | ||
| pubs = list(openalex.publications_from_dois(dois)) | ||
| assert len(pubs) == 231, "should paginate (page size=200)" |
There was a problem hiding this comment.
Make sure we got back more than 200 that demonstrates that paging is working.
lwrubel
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A batch size of 75 exceeds the default page size of 50, which means 25 DOIs will not be returned, unless pagination is used. This commit adds pagination with a page size of 200 (the max) and modifies the test to make sure that the pagination is happening by trying to get metadata for 250 DOIs.