Pass DimensionContentCollection to DataMapper services #182
Conversation
| /** | ||
| * @implements \IteratorAggregate<DimensionContentInterface> | ||
| */ | ||
| class PreviewDimensionContentCollection implements \IteratorAggregate, DimensionContentCollectionInterface |
There was a problem hiding this comment.
Not sure about this class. Can we mark it as @internal at current state.
|
|
||
| public function getDimensionAttributes(): array | ||
| { | ||
| return ['locale' => $this->previewLocale]; |
There was a problem hiding this comment.
A DimensionCollection should always return all its DimensionAttributes so we should array_merge() them here with the getDefaultDimensionAttributes.
| public function count(): int | ||
| { | ||
| return 1; | ||
| } |
There was a problem hiding this comment.
Not really happy with this :(
There was a problem hiding this comment.
Not sure if we should return here 2 to simulate that we have a unlocalized and localizedObject.
There was a problem hiding this comment.
think i would not return 2 because that is misleading
There was a problem hiding this comment.
i could adjust the DimensionContentCollectionInterface to not extend Countable as described in #178 to get rid of the method 😇
niklasnatter
force-pushed
the
enhancement/mapper-collection-parameter
branch
from
ee772bc
to
75419a7
Compare
|
@alexander-schranz Not really happy about the preview handling too, but I dont have a better idea at the moment. Do you see a better alternative? |
Content/Application/ContentDataMapper/DataMapper/DataMapperInterface.php
Show resolved
Hide resolved
alexander-schranz
deleted the
enhancement/mapper-collection-parameter
branch
This PR aadjust the
ContentDataMapperservice and theDataMapperservices to accept aDimensionContentCollectionparameter instead of aunlocalizedObjectand an optionallocalizedObjectparameter.This makes the interfaces more flexible and consistent to other parts of the bundle.