Add Tip for Tags in TrashItemHandler #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
requested changes
Feb 4, 2022
bundles/trash.rst
Outdated
Comment on lines
120
to
124
| .. Tip:: | ||
|
|
||
| If `TrashItemHandler` is created outside of a Sulu sulu/skeleton application, for example in a separate bundle, the automatic autowire of the Trash bundle does not work. | ||
| In this case the handler must be tagged with the following tags. | ||
| ``sulu_trash.store_trash_item_handler`` , ``sulu_trash.restore_trash_item_handler`` and ``sulu_trash.restore_configuration_provider``. |
There was a problem hiding this comment.
We should add a tip with the specific tag after every code block and not only to one of the blocks:
bundles/trash.rst
Outdated
| @@ -117,6 +117,13 @@ with the correct data. | |||
| } | |||
| } | |||
|
|
|||
| .. Tip:: | |||
|
|
|||
| If `TrashItemHandler` is created outside of a Sulu sulu/skeleton application, for example in a separate bundle, the automatic autowire of the Trash bundle does not work. | |||
There was a problem hiding this comment.
Would here go with the same links and wording like in the symfony documentation:
If you're using the default services.yaml configuration, this example will already work! Otherwise, create a service for this class and tag it with
sulu_trash.store_trash_item_handler.
|
@alexander-schranz added your suggestions, please have a final look :) |
alexander-schranz
approved these changes
Apr 26, 2024
|
@TheCadien Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add a Tip for Tagging the TrashItemHandler in External Services
Why?
Missing Docs