Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync: commaai/panda:master into sunnypilot/panda:master-new #62

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

sunnyhaibin
Copy link
Collaborator

@sunnyhaibin sunnyhaibin commented Jan 16, 2025

No description provided.

Copy link

sourcery-ai bot commented Jan 16, 2025

Reviewer's Guide by Sourcery

This pull request synchronizes the commaai/panda:master branch into the sunnypilot/panda:master-new branch. It updates the Panda library, cppcheck version, and removes the python/uds.py file.

Class diagram showing UDS module changes

classDiagram
    class UdsClient {
        +read_data_by_identifier(uds_data_id)
    }
    note for UdsClient "Moved from panda.python.uds to opendbc.car.uds"

    class MessageTimeoutError
    class NegativeResponseError
    class InvalidSubAddressError
    class SESSION_TYPE
    class DATA_IDENTIFIER_TYPE
Loading

File-Level Changes

Change Details Files
Updated Panda library imports
  • Changed import paths from panda.python.uds to opendbc.car.uds.
  • Added type ignore comment for uds_client.read_data_by_identifier(uds_data_id)
examples/query_fw_versions.py
Updated cppcheck version
  • Updated cppcheck version from 2.15.0 to 2.16.0
tests/misra/install.sh
Removed uds.py file
  • Removed the python/uds.py file.
  • Updated __init__.py and tests/misra/checkers.txt accordingly
python/uds.py
__init__.py
tests/misra/checkers.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sunnyhaibin - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sunnyhaibin sunnyhaibin merged commit 96632fa into master-new Jan 16, 2025
10 checks passed
@sunnyhaibin sunnyhaibin deleted the sync-20250116 branch January 16, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants