-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added count to ModeledResponse #103
Added count to ModeledResponse #103
Conversation
Hey @DanielW093, thanks for adding that! Can you add a test case for that change? |
Of course, happy to :) |
@DanielW093, I’ve been thinking, instead of adding a new method, why don’t we just add a |
If you think that makes more sense then I'll defer to your judgement! I'll admit I didn't dig too deeply into the codebase before making this change, so if that's better and more consistent with other libraries then that's probably the right approach |
Sure, so let's go with the |
@grdsdev I've implemented my version of the suggested change and added tests, it all appears to be working as expected in my project |
d09f7be
to
f56a2bc
Compare
Thanks @DanielW093 |
What kind of change does this PR introduce?
Added count to ModeledResponse, with ability to specify what kind of count should be retrieved