Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exchange code for session now fully async #378

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

silentworks
Copy link
Contributor

@silentworks silentworks commented Nov 29, 2023

What kind of change does this PR introduce?

Bug fix: change exchange_code_for_session to async method

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (08bada3) 45.40% compared to head (a8afd06) 45.37%.
Report is 2 commits behind head on main.

❗ Current head a8afd06 differs from pull request most recent head a249ba0. Consider uploading reports for the commit a249ba0 to get more accurate results

Files Patch % Lines
gotrue/_async/gotrue_client.py 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
- Coverage   45.40%   45.37%   -0.04%     
==========================================
  Files          23       23              
  Lines        1958     1955       -3     
==========================================
- Hits          889      887       -2     
+ Misses       1069     1068       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silentworks silentworks force-pushed the silentworks/async-pkce-flow branch from b5fca51 to a8afd06 Compare November 30, 2023 00:06
BREAKING CHANGE: change async method on_auth_state_change to sync only.
@silentworks silentworks force-pushed the silentworks/async-pkce-flow branch from a8afd06 to a249ba0 Compare November 30, 2023 01:00
@silentworks silentworks merged commit c294568 into main Nov 30, 2023
10 checks passed
@silentworks silentworks deleted the silentworks/async-pkce-flow branch November 30, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants