Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use direct DbHost from response in branches get #3056

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

takumihara
Copy link

What kind of change does this PR introduce?

This is a bug fix for the branches get command. Currently, it returns an incorrect host in the PostgreSQL URL.

What is the current behavior?

The PostgreSQL URL contains a redundant db.***.supabase.co.

> supabase branches get --experimental --output json                                                                                         develop
{
  "POSTGRES_URL": "postgresql://postgres:[password]@db.db.[project-id].supabase.co.supabase.co:5432/?connect_timeout=10"
}

What is the new behavior?

> go run . branches get --experimental --output json
{
  "POSTGRES_URL": "postgresql://postgres:[password]@db.[project-id].supabase.co:5432/?connect_timeout=10"
}

@takumihara takumihara requested a review from a team as a code owner January 19, 2025 03:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12850072932

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 58.367%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/branches/get/get.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 12825243990: -0.02%
Covered Lines: 7590
Relevant Lines: 13004

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants