Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(postgrest-config): add delete command to cli for convenience #3060

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

avallete
Copy link
Member

@avallete avallete commented Jan 21, 2025

What kind of change does this PR introduce?

Add a new delete subcommand to posgres-config allowing to restore override values back to default ones more easily.

Usage:

# Delete a single configuration parameter
supabase postgres-config delete --config max_connections

# Delete multiple configuration parameters (comma-separated, no spaces)
supabase postgres-config delete --config max_wal_size,effective_cache_size,shared_buffers

# Delete configuration without restarting the database
supabase postgres-config delete --config work_mem,maintenance_work_mem --no-restart

Closes DEVW-324

@avallete avallete requested a review from a team as a code owner January 21, 2025 08:43
Copy link

linear bot commented Jan 21, 2025

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12883173988

Details

  • 0 of 26 (0.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 58.216%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/postgresConfig/delete/delete.go 0 26 0.0%
Files with Coverage Reduction New Missed Lines %
internal/debug/postgres.go 3 64.86%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 12866624157: -0.2%
Covered Lines: 7589
Relevant Lines: 13036

💛 - Coveralls

@avallete avallete merged commit 3f52227 into develop Jan 22, 2025
13 checks passed
@avallete avallete deleted the feat/add-postgres-config-delete-command branch January 22, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants