-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: search objects v2 #626
base: master
Are you sure you want to change the base?
Conversation
a5b7fe6
to
96b7825
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. In overall all looks good to me. I just left couple of comments below.
96b7825
to
831465a
Compare
Pull Request Test Coverage Report for Build 13197575053Details
💛 - Coveralls |
cd1f59e
to
f7be9ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes. LGTM.
f7be9ad
to
19df503
Compare
⛔ Snyk checks have failed. 1 issues have been found so far.
⛔ code/snyk check is complete. 1 issues have been found. (View Details) |
ca62e66
to
1d2d112
Compare
cursor, | ||
}) | ||
|
||
return response.status(200).send(results) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cross-site Scripting (XSS)
Unsanitized input from an HTTP parameter
flows into send
, where it is used to render an HTML page returned to the user. This may result in a Cross-Site Scripting attack (XSS).
Line 69 | CWE-79 | Priority score 789 | Learn more about this vulnerability
Data flow: 11 steps
Step 1 - 4
const { bucketName } = request.params |
Step 5 - 9
src/http/routes/object/listObjectsV2.ts#L62
Step 10 - 11
return response.status(200).send(results) |
1d2d112
to
acca57f
Compare
What kind of change does this PR introduce?
Feature
What is the current behavior?
Super slow search functionality when there are millions of objects
What is the new behavior?
Fast, reliable and performant search functionality across hundreds of millions of objects