chore: Generate coverage reports and upload them. #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dshukertjr I see this has been marked as ready for review, but I see no report on coveralls, is it working already? |
|
@grdsdev I think so. The upload action has succeeded: https://github.com/supabase/supabase-flutter/actions/runs/13031130088/job/36350498930?pr=1110 |
|
@dshukertjr I think you still need to add a step for uploading to coveralls instead of GH artifacts, I see a 0% coverage on https://coveralls.io/github/supabase/supabase-flutter |
|
Should be good now |
grdsdev
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Generate coverage reports for each package and upload them.
A new GitHub actions workflow file,
coverage.ymlis introduced, which runs the test for all the packages, generates coverage reports, combines them, and uploads them. This test is redundant as the tests are also run in each individual CI pipeline, but after struggling a bit trying to combine the coverage reports from multiple different workflows, I settled with this implementation.This PR also includes minor type fix and test stub fix in the realtime rep.