Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): nullish coalescing operator issue in hasCustomAuthorizationHeader #1344

Merged

Conversation

raghavyuva
Copy link
Contributor

fixes the following bug :

The left operand of the "??" operator here will never be null or undefined, so it will always be returned.

What kind of change does this PR introduce?

Bug fix

Please link any relevant issues here.
#1338

…nHeader

fixes the following bug : The left operand of the "??" operator here will never be null or undefined, so it will always be returned.

supabase#1338
@avallete avallete changed the title fix: 🐛 Fix nullish coalescing operator issue in hasCustomAuthorizationHeader fix(lint): nullish coalescing operator issue in hasCustomAuthorizationHeader Jan 17, 2025
Copy link
Member

@avallete avallete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍

@avallete avallete merged commit 76217a4 into supabase:master Jan 17, 2025
1 check passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12463952292

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 67.488%

Totals Coverage Status
Change from base Build 12408933318: -0.1%
Covered Lines: 99
Relevant Lines: 128

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants