Check for host and status page issues async #4125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetch issues at the start of command, and display at the end. If the command completes before the check has completed, don't block waiting for the response. This optimizes for fast CLI command completion, optionally displaying issues when possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
Fetch host + statuspage issues at the start of CLI commands, and displays them at the end (if any exist). If the command completes before the check has completed, don't block waiting for the response.
This optimizes for fast CLI commands, optionally displaying issues when possible.
How:
Moves the queries into a goroutine, and passes the results through a channel received by a task finalizer at the end of a command.
Related to:
Documentation