Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix call for await _scemaUpdatesListener #240

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix call for await _scemaUpdatesListener #240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/memphis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,16 +864,16 @@ class Memphis {
'send_notification',
createRes.send_notification
);
await this._scemaUpdatesListener(stationName, createRes.schema_update);
var partitions: number[]
if (createRes?.partitions_update === undefined || createRes?.partitions_update === null || createRes?.partitions_update?.partitions_list === null) {
partitions = [];
} else {
partitions = createRes.partitions_update.partitions_list;
}
this.stationPartitions.set(internal_station, partitions);

const producer = new Producer(this, producerName, stationName, realName, partitions);
await this._scemaUpdatesListener(stationName, createRes.schema_update);
this.setCachedProducer(producer);

return producer;
Expand Down Expand Up @@ -990,7 +990,6 @@ class Memphis {
let partitions = []
try {
createRes = this.JSONC.decode(createRes.data);
await this._scemaUpdatesListener(stationName, createRes.schema_update);
if (createRes.error != '') {
throw MemphisError(new Error(createRes.error));
}
Expand All @@ -1006,7 +1005,7 @@ class Memphis {
}
}
this.stationPartitions.set(internal_station, partitions);

// the least possible value for batchMaxTimeToWaitMs is 1000 (1 second)
batchMaxTimeToWaitMs = batchMaxTimeToWaitMs < 1000 ? 1000 : batchMaxTimeToWaitMs;
const consumer = new Consumer(
Expand All @@ -1025,7 +1024,8 @@ class Memphis {
partitions,
consumerPartitionKey,
consumerPartitionNumber
);
);
await this._scemaUpdatesListener(stationName, createRes.schema_update);
this.setCachedConsumer(consumer);

return consumer;
Expand Down