[WIP] feat: skip field validations on non signup routes #920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
From my understanding of the ticket, we wanted to avoid doing field validations on form fields for non-signup routes, since it is field validation that emits FORM_FIELD errors. This would mean we would be delegating the validation to the core, for say email and password. Please feel free to let me know if this is not the intended change of the ticket and if it is to be done differently. I am quite new to the repo so my understanding is quite limited. I am happy to do it the right way with little guidance. Thank you for your time and patience.
Related issues
Test Plan
I have yet to run the test cases and update them if necessary, will do it once I get a go on the implementation
Documentation changes
This might need a Docs update as mentioned in the ticket.
Checklist for important updates
package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.Remaining TODOs for this PR