Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relax constraint on aiosmtplib lib #482

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

anku255
Copy link
Contributor

@anku255 anku255 commented Apr 5, 2024

Summary of change

This PR relaxes constraint on aiosmtplib library.

Related issues

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

@rishabhpoddar rishabhpoddar changed the base branch from master to 0.18 April 5, 2024 13:08
setup.py Outdated
@@ -110,7 +110,7 @@
"Deprecated==1.2.13",
"phonenumbers==8.12.48",
"twilio==7.9.1",
"aiosmtplib==1.1.6",
"aiosmtplib>=1.1.6,<=3.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not make it < 4.0.0 ? I assume between 3.0.1 and 4.0.0, they wont have any breaking change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I have updated it.

@rishabhpoddar rishabhpoddar merged commit 7a3aca0 into 0.18 Apr 8, 2024
3 of 4 checks passed
@rishabhpoddar rishabhpoddar deleted the fix/relax-aiosmtplib branch April 8, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants