Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improved readability in parsetContent() #16

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

supitsdu
Copy link
Owner

Implement changes reviewed here

  • Handle each case in parseContent separately for clarity.
  • Integrate the updated parseContent into the main.go.
  • Ensure consistent error handling and function documentation.

Closes #14

- Handle each case in parseContent separately for clarity.
- Integrate the updated parseContent into the main.go.
- Ensure consistent error handling and function documentation.
@supitsdu supitsdu added the refactoring Issues or PRs to improving code structure, without changing its external behavior label Jun 24, 2024
@supitsdu supitsdu self-assigned this Jun 24, 2024
@ccoVeille
Copy link
Contributor

This PR completes the changes made with #15 for #14

@karimalzalek
Copy link
Contributor

Hello @supitsdu and @ccoVeille , looks simpler now, sorry for missing the review.

@ccoVeille
Copy link
Contributor

My bad also, so no problem

@supitsdu supitsdu merged commit 0b0c13e into main Jun 25, 2024
1 check passed
@supitsdu supitsdu deleted the 14-reduce-complexity-when-parsing-content branch June 25, 2024 03:31
@supitsdu
Copy link
Owner Author

Hello @supitsdu and @ccoVeille , looks simpler now, sorry for missing the review.

Don't worry mate, it was my bad. I should've seen the review made by @ccoVeille. Thank you both for the contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Issues or PRs to improving code structure, without changing its external behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce complexity when parsing content
3 participants