feat: Update logs and enhance ContentReader.ReadAll logic #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve the logic inside ContentReader.ReadAll Function - Add more description info for each error - Add success message to describe the size of the contents copied to the clipboard - Improve the format of the Usage page
supitsdu
added
enhancement
ccoVeille
suggested changes
Jul 15, 2024
Replace new line escape codes with fmt.Fprintf(flag.CommandLine.Output()) for better readability as suggest by @ccoVeile
Update some logical and structural problems in the code following the recommendations made by @ccoVeille
ccoVeille
reviewed
Aug 2, 2024
|
Hi, I experienced quite an incident that I wasn't expecting to happen a few weeks ago, which made me be offline for a bit. After slowing down the development of this and other projects, I'm working to get things sorted while I'm still on vacation (I have a week left tho 😅) I much appreciate the reviews made by @ccoVeille. As always helps me a lot in learning Go and developing Clipper, Thanks 🤗 |
Co-authored-by: ccoVeille <[email protected]>
|
My pleasure. Enjoy your last week of holidays. And more important, take care of you |
…nd debugging - Added detailed error messages to `require` and `assert` statements in `TestReadAll`, `TestReadable`, `TestIOReader`, `TestCreateContent`, and `TestJoinAll` - Improved context in test assertions to facilitate easier debugging and maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26