-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add class and style to table column #13
base: main
Are you sure you want to change the base?
Conversation
It also can be used to set the column width directly until we have a solution for #10. |
Hey @olivermt! I realized that for a more generic solution, it would be nice to also have a |
@msaraiva I am thinking we should probably split this into header_class and item_class so we have an easy way to propagate styles down to each as well. |
Also this is just raw styles right? I am not completely sold on having that as an api in a css driven framework. I am thinking that we shouldnt expose a style prop until we're sure how we want to integrate flex layout to tables with the bigger bulma picture. |
I have a suggestion, what if we had a Style component that is collected via macros and is embeddable in as a scss combinator? Isn't that similar to what you were discussing in the issue over in Surface? |
But a
I think we should have both. It's really hard to predict all scenarios the user might need. Eventually, we'll need to make a choice and pick up a specific API as default (like the one you suggested) but I still think users may need to do extra customizations that we'll not be able to bring as standard API so exposing
I believe it's very similar. |
Anyway, the decision is totally yours. If you have any doubt that this is the way to go, feel free to close the PR. It's your baby now 😉 You could, however, keep the playground and update the catalogue version. It's really cool to play with the component's properties and see how they affect the visual of the table 🙂 |
This PR adds a style prop to
<Column>
. This way the user can customize the<th>
style directly. I also updatedsurface_catalogue
to the latest version and created a playground for the table.