Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: division by zero error #1515

Merged
merged 1 commit into from
Jun 23, 2024
Merged

fix: division by zero error #1515

merged 1 commit into from
Jun 23, 2024

Conversation

0xMasayoshi
Copy link
Contributor

@0xMasayoshi 0xMasayoshi commented Jun 23, 2024

PR-Codex overview

This PR updates the logic in simple-swap-header.tsx to check for quotient property in token0Price and token1Price objects before assigning them to price.

Detailed summary

  • Added null check for quotient property in token0Price and token1Price before creating a new Price instance.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jun 23, 2024

⚠️ No Changeset found

Latest commit: a49bc6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@sushiswap/wagmi" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package "aptos" depends on the ignored package "@sushiswap/react-query", but "aptos" is not being ignored. Please add "aptos" to the `ignore` option.
The package "tron" depends on the ignored package "@sushiswap/react-query", but "tron" is not being ignored. Please add "tron" to the `ignore` option.
The package "aptos" depends on the ignored package "@sushiswap/ui", but "aptos" is not being ignored. Please add "aptos" to the `ignore` option.
The package "tron" depends on the ignored package "@sushiswap/ui", but "tron" is not being ignored. Please add "tron" to the `ignore` option.

Copy link

vercel bot commented Jun 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 3:34am
aptos ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 3:34am
blog ❌ Failed (Inspect) Jun 23, 2024 3:34am
evm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 3:34am
token-list ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 3:34am
tokens ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 3:34am
tron ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 3:34am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants