💚 Fix "check-diff" build.

.devcontainer/devcontainer.json

@@ -23,7 +23,7 @@
 		"ghcr.io/devcontainers-extra/features/tfswitch:1": {}
 	},
 
-	"onCreateCommand": "tfswitch -b /home/vscode/terraform 1.5.7 ; helm repo add jfrog https://charts.jfrog.io ; go install github.com/magefile/[email protected] ; go install github.com/onsi/ginkgo/v2/ginkgo",
+	"onCreateCommand": "tfswitch -b /home/vscode/terraform 1.5.7 ; helm repo add jfrog https://charts.jfrog.io ; go install github.com/magefile/[email protected] ; go install github.com/onsi/ginkgo/v2/ginkgo ; go install golang.org/x/tools/cmd/[email protected]",
 	"updateContentCommand": "go install github.com/golangci/golangci-lint/cmd/golangci-lint@v$(grep -E '^GOLANGCILINT_VERSION[[:space:]]*\\?=[[:space:]]*[[:digit:][:punct:]]*' Makefile | cut -d'=' -f2 | tr -d '[:space:]')",
 	"remoteEnv": {
 		"PATH": "${containerEnv:PATH}:/home/vscode",

config/external_name.go

@@ -10,7 +10,7 @@ import "github.com/crossplane/upjet/pkg/config"
 // provider.
 var ExternalNameConfigs = map[string]config.ExternalName{
 	// Import requires using a randomly generated ID from provider: nl-2e21sda
-	"artifactory_unmanaged_user":           config.NameAsIdentifier,
+	// TODO: Not implemented yet: "artifactory_unmanaged_user":           config.NameAsIdentifier,
 	"artifactory_local_generic_repository": config.ParameterAsIdentifier("key"),
 }
 

e2e/e2e_test.go

@@ -69,7 +69,7 @@ var _ = Describe("E2E Tests", func() {
 					},
 					Spec: v1alpha1.GenericRepositorySpec{
 						ForProvider: v1alpha1.GenericRepositoryParameters{
-							Key: ptr.To("UNUSED-repo-key"),
+							Description: ptr.To("Test repository"),
 						},
 						ResourceSpec: v1.ResourceSpec{
 							ProviderConfigReference: &v1.Reference{
@@ -111,6 +111,7 @@ var _ = Describe("E2E Tests", func() {
 				err = rtClient.GetRepository("test-repo", &repoDetails)
 				Expect(err).NotTo(HaveOccurred())
 				Expect(repoDetails.Key).To(Equal("test-repo"))
+				Expect(repoDetails.Description).To(Equal("Test repository"))
 				Expect(repoDetails.GetRepoType()).To(Equal("local"))
 				Expect(repoDetails.PackageType).To(Equal("generic"))
 			})

package/crds/repository.upbound.io_genericrepositories.yaml

@@ -108,11 +108,6 @@ spec:
                       When used, only artifacts matching one of the include patterns
                       are served. By default, all artifacts are included (`**/*`).
                     type: string
-                  key:
-                    description: A mandatory identifier for the repository that must
-                      be unique. Must be 1 - 64 alphanumeric and hyphen characters.
-                      It cannot contain spaces or special characters.
-                    type: string
                   notes:
                     description: Internal description.
                     type: string
@@ -200,11 +195,6 @@ spec:
                       When used, only artifacts matching one of the include patterns
                       are served. By default, all artifacts are included (`**/*`).
                     type: string
-                  key:
-                    description: A mandatory identifier for the repository that must
-                      be unique. Must be 1 - 64 alphanumeric and hyphen characters.
-                      It cannot contain spaces or special characters.
-                    type: string
                   notes:
                     description: Internal description.
                     type: string
@@ -411,11 +401,6 @@ spec:
             required:
             - forProvider
             type: object
-            x-kubernetes-validations:
-            - message: spec.forProvider.key is a required parameter
-              rule: '!(''*'' in self.managementPolicies || ''Create'' in self.managementPolicies
-                || ''Update'' in self.managementPolicies) || has(self.forProvider.key)
-                || (has(self.initProvider) && has(self.initProvider.key))'
           status:
             description: GenericRepositoryStatus defines the observed state of GenericRepository.
             properties:
@@ -458,11 +443,6 @@ spec:
                       When used, only artifacts matching one of the include patterns
                       are served. By default, all artifacts are included (`**/*`).
                     type: string
-                  key:
-                    description: A mandatory identifier for the repository that must
-                      be unique. Must be 1 - 64 alphanumeric and hyphen characters.
-                      It cannot contain spaces or special characters.
-                    type: string
                   notes:
                     description: Internal description.
                     type: string