fix: Use StrongPtr::retain on class methods #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natsuki Ikeguchi <[email protected]>
|
Thanks for the bug fix. However, we would appreciate it if you could wait for a while to merge this fix. We would probably prefer to eliminate the autorelease object and solve everything with |
|
@suzusuzu Thank you for the investigation. If this pull request resolves the issue not in a good way, feel free to close and supersede it. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4
I am not good at Objective-C and/or macOS things, so I do not know this is the correct resolution of this issue. However I confirmed this works without occurring any segmentation faults.