-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add note for gh-pages cli to adapter static docs #13309
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Kuiliang Zhang <[email protected]>
|
preview: https://svelte-dev-git-preview-kit-13309-svelte.vercel.app/ this is an automated message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should be adding docs for third-party tools to our docs. tschaub/gh-pages
isn't an official package and I think the docs would become messy quickly if we had to document every third-party client
Co-authored-by: Ben McCann <[email protected]>
I was going to say the same thing too. However, I changed my mind because I can't imagine there would be a litany of these to add, and it might save someone some time or frustration if they're using this tool. Generally, I think that documenting more cases is helpful and this tool seems to have decent usage. |
accident
#13302 seemed to break, so re-opened it here with suggestions applied
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits