Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch error when resolving peer dep #13334

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Jan 17, 2025

supplements #12532 (hopefully before #13316 is merged)
fixes #13331

While testing the fix from #12532 with the reproduction from #13331 I found that the resolve function throws an uncaught error on line 13

const resolved = imr.resolve(dependency, pathToFileURL(process.cwd() + '/dummy.js'));

This PR ensures that the resolve error is caught then tries the relative import, similar to the previous behaviour of importing svelte/compiler https://github.com/sveltejs/kit/pull/12532/files#diff-61bc3314d549d23c68f49ea0467f8856c97f8f5f3e150b4b529668f0cbaad7a1 before #12532 was merged


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jan 17, 2025

⚠️ No Changeset found

Latest commit: b2c6c8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13334-svelte.vercel.app/

this is an automated message

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this!

@dummdidumm dummdidumm merged commit 388d441 into main Jan 17, 2025
13 checks passed
@dummdidumm dummdidumm deleted the fix-resolve-peer-dep branch January 17, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't support vitest workspaces
3 participants