fix: catch error when resolving peer dep #13334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supplements #12532 (hopefully before #13316 is merged)
fixes #13331
While testing the fix from #12532 with the reproduction from #13331 I found that the
resolve
function throws an uncaught error on line 13kit/packages/kit/src/utils/import.js
Line 13 in 0142dd8
This PR ensures that the resolve error is caught then tries the relative import, similar to the previous behaviour of importing svelte/compiler https://github.com/sveltejs/kit/pull/12532/files#diff-61bc3314d549d23c68f49ea0467f8856c97f8f5f3e150b4b529668f0cbaad7a1 before #12532 was merged
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits