-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add docs on state_unsafe_mutation error #14932
base: main
Are you sure you want to change the base?
Conversation
|
preview: https://svelte-dev-git-preview-svelte-14932-svelte.vercel.app/ this is an automated message |
|
I think it would be helpful to use an example where the mutated state is independent of the derived — it's easy to look at the current example and think 'well of course you can't update the thing the result depends on', when actually it's nothing to do with the cyclicality. I'd guess that most people are encountering a non-cyclical version of this problem (i.e. treating the derived as a convenient place to update some independent state). Ideally the example would reflect real cases — @MathiasWP do you recall what sort of things led to you encountering this error? |
I've gone on a scavenge hunt to try and find the code that caused this, but with no luck (it was quite difficult to find in the first place when it happened) :/ |
In the absence of a better real world example, I'd like to merge this. Any objections? |
I've figured out an example of why this happened with us, and essentially it is the same as documented here, but a lot more hidden. We have repositories that fetch external data based on the parameters passed into a It's intuitive to use the repository in a derived method to make it fetch new data when state updates, but one of the services used in the repository may trigger update of a rune in another class, which isn't always that easy to spot. We've managed to fix this case, but it's an example of where it's a little bit hidden that a state rune actually was updated by a method used in a derived rune. So we've had to figure out why runes and stores behaves different (when it essentially feels like the same thing), which in result has made us scratch our heads when migrating to Svelte 5. |
closes #14752