Delayed message support for memory, rabbitmq, redis #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-onelson
commented
Oct 31, 2023
There was a problem hiding this comment.
This is a hatchet job based on what you'll see in https://github.com/svix/svix-webhooks/blob/main/server/svix-server/src/queue/redis.rs
Could be useful to review the original while reading this module.
svix-onelson
force-pushed
the
onelson/memory-queue-refactor
branch
from
02f369d
to
a78dd7b
Compare
svix-onelson
commented
Nov 1, 2023
omniqueue/src/backends/redis/mod.rs
Outdated
Comment on lines
285
to
288
| // FIXME(onelson): original impl depends on chrono so it can convert to UTC. Should probably do this too. | ||
| let timestamp: i64 = std::time::SystemTime::now() | ||
| .duration_since(std::time::UNIX_EPOCH) |
There was a problem hiding this comment.
Seems like this is good as-is. I verified that SystemTime gives UTC time, regardless of the TZ selection for the process.
Put another way, where running env TZ=America/New_York date shows the tz shift away from my system default of America/Los_Angeles, the output from SystemTime is stable.
svix-onelson
force-pushed
the
onelson/memory-queue-refactor
branch
3 times, most recently
from
eb0bf1e
to
b759f6e
Compare
SQS already had support for delays. This diff adds support for all the remaining backends _except for GCP_ which does not provide a direct way to emulate the delay behavior. The redis impl is by far the most complicated of the bunch. This version was based heavily on what was built for the OSS svix-server, with adjustments needed to account for "raw payloads" which omniqueue uses for persistence rather than encoding things as JSON. A single e2e test for each backend was added to demonstrate the delay behavior.
svix-onelson
force-pushed
the
onelson/memory-queue-refactor
branch
from
b759f6e
to
c9323b3
Compare
svix-onelson
commented
Nov 1, 2023
|
Looks good to me. |
svix-james
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQS already had support for delays.
This diff adds support for all the remaining backends except for GCP which does not provide a direct way to emulate the delay behavior.
The redis impl is by far the most complicated of the bunch. This version was based heavily on what was built for the OSS svix-server, with adjustments needed to account for "raw payloads" which omniqueue uses for persistence rather than encoding things as JSON.
A single e2e test for each backend was added to demonstrate the delay behavior.