Replace async_trait usage with RPITIT / AFIT #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Delivery has no public constructor, it is impossibly to write a functional QueueConsumer outside of omniqueue. This commit should be reverted when that deficiency is fixed.
This commit likely needs to be reverted to add support for custom queue backends.
svix-jplatte
force-pushed
the
jplatte/tait
branch
from
9029609
to
43b260d
Compare
svix-jplatte
changed the title
svix-jplatte
changed the title
… for our own public traits.
svix-jplatte
force-pushed
the
jplatte/tait
branch
from
43b260d
to
5dddc7a
Compare
svix-gabriel
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for our own public traits. This is primarily a docs improvement, but also removes unnecessary boxing of futures.
Details about the funny abbreviations: https://blog.rust-lang.org/2023/12/21/async-fn-rpit-in-traits.html
Before:
After: