Honour APP_ENV as an alternative to RODBOT_ENV

CHANGELOG.md

@@ -3,6 +3,7 @@
 #### Changes
 * Adhere to plugin file layout suggestions
 * Support Ruby 3.3
+* Honor `APP_ENV` as an alternative to `RODBOT_ENV`
 
 ## 0.4.3
 

README.md

@@ -468,6 +468,8 @@ Rodbot.env.production?    # => true
 Rodbot.env.development?   # => false
 ```
 
+You can use the more generic alternative `APP_ENV` as well, however, if `RODBOT_ENV` is defined, it takes precedence over `APP_ENV`.
+
 ## Credentials
 
 In order not to commit secrets to repositories or environment variables, Rodbot bundles the [dry-credentials](https://rubygems.org/gems/dry-credentials) gem and exposes it via the `rodbot credentials` CLI command. The secrets are then available in your code like `Rodbot.credentials.my_secret` and the encrypted files are written to `config/credentials`.

lib/rodbot/env.rb

@@ -27,7 +27,7 @@ def initialize(root: nil)
       @root = root ? Pathname(root).realpath : Pathname.pwd
       @tmp = @root.join('tmp')
       @gem = Pathname(__dir__).join('..', '..').realpath
-      @current = ENV['RODBOT_ENV']
+      @current = ENV['RODBOT_ENV'] || ENV['APP_ENV']
       @current = 'development' unless ENVS.include? @current
     end
 

spec/lib/rodbot/env_spec.rb

@@ -51,4 +51,20 @@
       end
     end
   end
+
+  describe 'APP_ENV environment variable' do
+    it "sets the environment" do
+      with "ENV['APP_ENV']", 'production' do
+        with "ENV['RODBOT_ENV']", nil do
+          _(subject).must_be :production?
+        end
+      end
+    end
+
+    it "RODBOT_ENV takes precedence" do
+      with "ENV['APP_ENV']", 'production' do
+        _(subject).must_be :test?
+      end
+    end
+  end
 end