fix: migrate intro page to new mollie sdk #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does not resolve #1159, but that's out of scope |
SilasPeters
force-pushed
the
feat/onboarding
branch
from
b4aac7b to
0c36e6e
Compare
SilasPeters
commented
Feb 2, 2025
There was a problem hiding this comment.
I tested this but again not fully because I don't use ngrok to make mollie work. @leuke-naam we really need documentation on this
|
Undead-mongoose has some documentation on how to use ngrok with it, so we can copy that and adapt it a little. |
|
Should we perhaps merge now because of the first-year students activity tomorrow? |
|
It has been a massive pain to get this tested, adding account requires the mailer to work or have database access, neither of them particularly convenient. So we might want to make some utilities for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically removes the option to select a bank, which is deprecated.