Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the scroll to top with enhanced ui and fixed someone has putted the css directly on button which is bad habbit fixed that #112

Closed
wants to merge 7 commits into from

Conversation

tarunkumar2005
Copy link
Contributor

Pull Request Format

PR Title

#74 Adding "Scroll top down" feature to the webpage

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • [X ] Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

I have created the scroll to bottom button with enhanced ui and user experience looking very amazing and fixed some isses by inexperienced people directly applied styles to button it took me 3 min to find that someone has already applied the styles directly to the button tag which is not good.

Screenshots / Videos (if applicable)

Before:

Recording.2024-10-04.224729.1.mp4

After:

Recording.2024-10-04.231231.1.mp4

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • [ X] I have tested the changes thoroughly before submitting this pull request.
  • [ X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [ X] I have commented my code, particularly in hard-to-understand areas.

Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ❌ Failed (Inspect) Oct 6, 2024 5:13am

@tarunkumar2005
Copy link
Contributor Author

@swaraj-das Check this and try to check on people who are doing like this applying styles directly on tag and so okay it is not good to do so. Merge it when you have checked this.

@swaraj-das
Copy link
Owner

@swaraj-das Check this and try to check on people who are doing like this applying styles directly on tag and so okay it is not good to do so. Merge it when you have checked this.

I have reviewed almost all the PR codes, and my friend Anit has also checked them. If there are any mistakes, they are not intentional. I understand that it’s not in line with coding conventions, so it’s important for all contributors to maintain proper practices moving forward.

@tarunkumar2005
Copy link
Contributor Author

@swaraj-das and @AnitSarkar123 If you have reviewed then you can add labels and assign it to me and merge it.

@tarunkumar2005
Copy link
Contributor Author

@swaraj-das and @AnitSarkar123 Please merge this PR if you have no issue i have by mistake added the new changes in the same PR which is not good can we talk over this please another issue i rasied and solved is merged into this PR only respond asp if you can

@tarunkumar2005
Copy link
Contributor Author

issue #110 is also done in this only by mistake i pushed it and it is committed here now

@tarunkumar2005
Copy link
Contributor Author

@swaraj-das and @AnitSarkar123 If you get time then you can tell me the conflicts are increasing with the the increase time so i will have to do more work in that case.

@AnitSarkar123
Copy link
Collaborator

AnitSarkar123 commented Oct 8, 2024

varcel can't deployed it so we can't marge it at this time ...also make this pr again with an another branch because 2 issues solved in one you can't get the points of the tow issues take the latest pull from it

Copy link
Collaborator

@AnitSarkar123 AnitSarkar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deployment failed and rise another pr

@tarunkumar2005
Copy link
Contributor Author

will create another PR for the scroll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants