Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Navbar and made some changes #130

Closed
wants to merge 4 commits into from

Conversation

Gahlotkumkum
Copy link

@Gahlotkumkum Gahlotkumkum commented Oct 5, 2024

Pull Request Format

PR Title

Issue #73

###Close #130

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

This pull request aims to [briefly describe what the pull request does, e.g., "add a new feature," "fix a bug," "improve documentation," etc.].

Screenshots / Videos (if applicable)

Before:

  • [Describe the state before the changes, e.g., "The section headings in the footer were misaligned, leading to an inconsistent and cluttered appearance."]

After:

  • [Describe the state after the changes, e.g., "The section headings in the footer are now properly aligned, providing a clean and professional look."]

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

[Provide any additional context about the changes, such as specific challenges you faced or decisions you made. This can help reviewers understand the rationale behind your changes.]

Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 3:13am

@Gahlotkumkum
Copy link
Author

@swaraj-das Check this and merge it.

<li><a href="#">VR Accessories</a></li>
<li><a href="#">Media Remotes</a></li>
<li><a href="#">Others</a></li>
<li class="login"><a href="login/login.html">Login</a></li>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the login button list element to button...and add hover effect.

@swaraj-das
Copy link
Owner

swaraj-das commented Oct 6, 2024

Points to be noted :

  1. Don't add hover effect to the navbar and fix the navbar
  2. Add some margin to the left of the logo and take all element as much middle.
  3. upgrade the login button.
  4. Add home, your carts, your profile and the given items in nav.

@Gahlotkumkum
Copy link
Author

Gahlotkumkum commented Oct 6, 2024

@swaraj-das First, merge it, then I'll clone it again to start working.

@Gahlotkumkum
Copy link
Author

Hey @swaraj-das consider it to merge in the main branch!!

@swaraj-das
Copy link
Owner

@Gahlotkumkum Merge conflicts. Please resolve it.

@Gahlotkumkum
Copy link
Author

Gahlotkumkum commented Oct 7, 2024

@swaraj-das Check this, Resolved all the conflicts.

@swaraj-das swaraj-das closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants