-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dockerfile docker-compose.yml #266
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for collect-your-gamingtools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hey @swaraj-das please review this PR |
@AnitSarkar123 Can you check it? |
@haseebzaki-07 we don't want dockerfile because dockerfile deployment is very costly |
@AnitSarkar123 We can use dockerfile to set up project locally in development process it is totally optional if you do not want to use it in deployment/production. It makes development process much easier as one does not need to install dependencies locally and resolve conflicts . Docker takes care of that in every environment the project runs be it be LINUX/MAC/WINDOWS Also initially Docker is free. I worked on the issue only because i was assigned so please consider that |
@haseebzaki-07 then can you please run mongodb on port 27017 on the docker-compose file and connect the app with the mongodb in a same network |
I mean run the backend and the frontend at the same time |
@AnitSarkar123 sure I will check it! |
OK👍 |
hey @AnitSarkar123 I have updated the docker-compose file to connect frontend backend and database all in the same network. Command to build and run the image : docker-compose up --build |
@haseebzaki-07 can you please give me a screenshot of the logs or picture then I will merge |
@AnitSarkar123 Here are the logs after docker builds the images and runs the application |
@haseebzaki-07 very good 👍 |
fixes #252
command to build the image : docker build -t gamingtool .
command to run the image : docker run -d -p 8080:80 gamingtool; Start-Process "http://localhost:8080"
Type of PR
Description
This PR dockerizes the Application
Screenshots / Videos (if applicable)
The command starts the application inside docker conatainer and the application is available on port 8080.
Checklist
Thank you for reviewing my pull request!