Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dockerfile docker-compose.yml #266

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

haseebzaki-07
Copy link
Contributor

@haseebzaki-07 haseebzaki-07 commented Oct 10, 2024

fixes #252

command to build the image : docker build -t gamingtool .
command to run the image : docker run -d -p 8080:80 gamingtool; Start-Process "http://localhost:8080"

Type of PR

  • Add X in the box to specify the improvement type.
  • [] Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

This PR dockerizes the Application

Screenshots / Videos (if applicable)

Screenshot 2024-10-10 143324

The command starts the application inside docker conatainer and the application is available on port 8080.

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 1:26pm

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 75b05d8
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/670a78eddf13a30008de439d
😎 Deploy Preview https://deploy-preview-266--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haseebzaki-07
Copy link
Contributor Author

hey @swaraj-das please review this PR

@swaraj-das
Copy link
Owner

@AnitSarkar123 Can you check it?

@AnitSarkar123
Copy link
Collaborator

@haseebzaki-07 we don't want dockerfile because dockerfile deployment is very costly

@haseebzaki-07
Copy link
Contributor Author

haseebzaki-07 commented Oct 12, 2024

@AnitSarkar123 We can use dockerfile to set up project locally in development process it is totally optional if you do not want to use it in deployment/production. It makes development process much easier as one does not need to install dependencies locally and resolve conflicts . Docker takes care of that in every environment the project runs be it be LINUX/MAC/WINDOWS

Also initially Docker is free. I worked on the issue only because i was assigned so please consider that

@AnitSarkar123
Copy link
Collaborator

@haseebzaki-07 then can you please run mongodb on port 27017 on the docker-compose file and connect the app with the mongodb in a same network

@AnitSarkar123
Copy link
Collaborator

@haseebzaki-07 then can you please run mongodb on port 27017 on the docker-compose file and connect the app with the mongodb in a same network

I mean run the backend and the frontend at the same time

@haseebzaki-07
Copy link
Contributor Author

@AnitSarkar123 sure I will check it!

@AnitSarkar123
Copy link
Collaborator

AnitSarkar123 commented Oct 12, 2024

@AnitSarkar123 sure I will check it!

OK👍

@haseebzaki-07
Copy link
Contributor Author

hey @AnitSarkar123 I have updated the docker-compose file to connect frontend backend and database all in the same network.

Command to build and run the image : docker-compose up --build

@AnitSarkar123
Copy link
Collaborator

@haseebzaki-07 can you please give me a screenshot of the logs or picture then I will merge

@haseebzaki-07
Copy link
Contributor Author

@AnitSarkar123 Here are the logs after docker builds the images and runs the application

Screenshot 2024-10-12 232404

Screenshot 2024-10-12 232327

Screenshot 2024-10-12 232302

@AnitSarkar123
Copy link
Collaborator

@AnitSarkar123 Here are the logs after docker builds the images and runs the application

Screenshot 2024-10-12 232404

Screenshot 2024-10-12 232327

Screenshot 2024-10-12 232302

@haseebzaki-07 very good 👍

@AnitSarkar123 AnitSarkar123 merged commit 220494c into swaraj-das:main Oct 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Dockerize the Application
3 participants