Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Added descriptive titles for all three buttons #363

Closed

Conversation

Sai-ganesh-0004
Copy link

@Sai-ganesh-0004 Sai-ganesh-0004 commented Oct 13, 2024

Pull Request Title

Issue #351 : Add Descriptive Titles to Icons solved

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update

Description

This pull request aims to enhance the user interface by adding hover effects for three buttons: the Dark Mode toggle, the Chatbox icon, and the Scroll to Top button. The hover effects provide users with visual feedback, improving usability and accessibility.

Screenshots / Videos (if applicable)

Before

  • The buttons did not provide any feedback on hover, making it unclear to users that they were interactive.
    IMG-20241013-WA0006
    IMG-20241013-WA0005

IMG-20241013-WA0007

After

  • The buttons now display hover text, improving user understanding and interaction. The hover text appears above the buttons, clearly indicating their function.
    IMG-20241013-WA0002
    IMG-20241013-WA0004
    IMG-20241013-WA0003
    IMG-20241013-WA0008
    IMG-20241013-WA0009

Checklist

  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

The hover effects were achieved using CSS pseudo-elements. I faced some challenges with positioning the hover text correctly, but adjustments were made to ensure that it appears neatly above the respective buttons. The implementation was tested in multiple browsers to ensure consistency.

Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 2:56pm

Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit b8a3183
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/670d3113856c640008a495d1
😎 Deploy Preview https://deploy-preview-363--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sai-ganesh-0004
Copy link
Author

Sai-ganesh-0004 commented Oct 13, 2024

after deploying it is working fine
once review
and let me know if any changes there

@swaraj-das
Copy link
Owner

@Sai-ganesh-0004 The chatbot button styling is changed, it should remain same.

@swaraj-das
Copy link
Owner

The 'chat with us' should in black type background like other namings you made

@Sai-ganesh-0004
Copy link
Author

@Sai-ganesh-0004 The chatbot button styling is changed, it should remain same.

Actually it is in black because as you directly bought it from the website chatbase i could not actually add descriptive title for as it is not an element in html or css so i installed a photo of the chatbox and when clicked on that it will open the chatbox

@Sai-ganesh-0004
Copy link
Author

@Sai-ganesh-0004 The chatbot button styling is changed, it should remain same.

Actually it is in black because as you directly bought it from the website chatbase i could not actually add descriptive title for as it is not an element in html or css so i installed a photo of the chatbox and when clicked on that it will open the chatbox

If you want i could put the orange chatbox icon instead of black one

@Sai-ganesh-0004
Copy link
Author

any updates

@github-actions github-actions bot added the Stale label Dec 2, 2024
@github-actions github-actions bot closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants