-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #187: [BUG] Add Functionality to VR Accessories Button and Create VR Product Page #364
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for collect-your-gamingtools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello @swaraj-das ,can you please review my PR & merge |
Sure ...I will make the changes as mentioned. |
Changes implemented. Please review @swaraj-das and merge if there are no other changes required |
2 similar comments
Changes implemented. Please review @swaraj-das and merge if there are no other changes required |
Changes implemented. Please review @swaraj-das and merge if there are no other changes required |
i request @swaraj-das to please review my pr, if there are any changes let me know .... |
Pull Request Format
PR Title
### Issue #187: [BUG] Add Functionality to VR Accessories Button and Create VR Product Page
Type of PR
Description
This pull request aims to fix the bug where the VR Accessories button in the navigation bar was non-functional. It now navigates users to a newly created VR Accessories page, showcasing products such as VR controllers, headsets, and other accessories. Each product displays an image, description, price, and an Add to Cart button for a seamless shopping experience.
Specific changes include:
Enabled navigation for the VR Accessories button.
Created a new VR Accessories page with a responsive product grid.
Added hover effects and dynamic product features, enhancing the user experience.
Screenshots / Videos (if applicable)
Before:
![before](https://private-user-images.githubusercontent.com/138043095/376011808-320e2469-09f9-4c7a-b962-63f76253ad37.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzOTM4NTUsIm5iZiI6MTczOTM5MzU1NSwicGF0aCI6Ii8xMzgwNDMwOTUvMzc2MDExODA4LTMyMGUyNDY5LTA5ZjktNGM3YS1iOTYyLTYzZjc2MjUzYWQzNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQyMDUyMzVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yMDBmMWVjNmE0MzgxM2MwNDkzYjc5ZjIwZTRjYzAwOTBlYWZjY2I0NTQyY2Q3ZGU1NDVlY2NmYWRjNTM4ZWFkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.1ta1WnN5hgND8HEmh3H0Y_eO7sXidK-K7-dLK_Asysk)
The VR Accessories button on the navigation bar was non-functional, and there was no dedicated VR accessories page.
After:
The button now navigates users to the VR Accessories page. This page displays product details in a grid format with hover effects and an Add to Cart button for each product.
after.mp4
Checklist
Add X in the box to specify.
I have performed a self-review of my code.
I have tested the changes thoroughly before submitting this pull request.
I have provided relevant issue numbers, screenshots, and videos after making the changes.
I have commented my code, particularly in hard-to-understand areas.
Additional Context
I have worked on this issue as part of GSSoC-ext 🎮 and made sure the design and functionality adhere to project standards. I would also like to kindly request if you could consider increasing the issue level to level 3 since this task involved both frontend development and improving the overall user experience, which took considerable effort.
Looking forward to your feedback! Thank you for your time and review!