-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#339 [BUG] Improve the review section by Ambar Mishra #371
Closed
ambarmishraa
wants to merge
22
commits into
swaraj-das:main
from
ambarmishraa:task-am/BUG-Improve-the-review-section-#339
Closed
#339 [BUG] Improve the review section by Ambar Mishra #371
ambarmishraa
wants to merge
22
commits into
swaraj-das:main
from
ambarmishraa:task-am/BUG-Improve-the-review-section-#339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Google Sign Up
Added the cart button
issue327fixed
Update Sidebar Toggle Functionality and Sidebar position updated
FEATURE : Underline Effect Added
adding annimation to buttons
Added Contributor's Page
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for collect-your-gamingtools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@ambarmishraa, could you please add some photos of the reviewers in that section? It would help enhance the design. |
ok I will do that Asap.! |
swaraj-das : You can now check the review section, its in the way you wished for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Format
#339 [BUG] Improve the review section by Ambar Mishra
Issue #339 : [BUG] Improve the review section solved
Type of PR
Description
This update enhances the review slider functionality by displaying three review cards at a time and cycling through them every three seconds, improving user experience on larger screens. Additionally, the previous implementation was not dynamic, as adding new cards would break the code; this version now accommodates new reviews seamlessly by recalculating indices, ensuring smooth transitions and efficient rendering.
Screenshots / Videos (if applicable)
Before:
-The height of the section was increasing on adding a new user review.
Working Video :
Screen.Recording.2024-10-14.223841.mp4
After:
-The card content automatically change without increasing the height of the section, even on adding many cards.
Checklist
Additional Context
The JavaScript logic ensures smooth transitions and efficient rendering by dynamically calculating which cards to show based on the current index.
Thank you for reviewing my pull request!