Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#339 [BUG] Improve the review section by Ambar Mishra #371

Conversation

ambarmishraa
Copy link

@ambarmishraa ambarmishraa commented Oct 13, 2024

Pull Request Format

#339 [BUG] Improve the review section by Ambar Mishra

Issue #339 : [BUG] Improve the review section solved

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

This update enhances the review slider functionality by displaying three review cards at a time and cycling through them every three seconds, improving user experience on larger screens. Additionally, the previous implementation was not dynamic, as adding new cards would break the code; this version now accommodates new reviews seamlessly by recalculating indices, ensuring smooth transitions and efficient rendering.

Screenshots / Videos (if applicable)

Before:
-The height of the section was increasing on adding a new user review.
Screenshot 2024-10-13 181949

Working Video :

Screen.Recording.2024-10-14.223841.mp4

After:
-The card content automatically change without increasing the height of the section, even on adding many cards.
Screenshot 2024-10-14 223353

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

The JavaScript logic ensures smooth transitions and efficient rendering by dynamically calculating which cards to show based on the current index.

Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 5:04pm

Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit a56c753
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/670d4f34281a020008d0466e
😎 Deploy Preview https://deploy-preview-371--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@swaraj-das
Copy link
Owner

@ambarmishraa, could you please add some photos of the reviewers in that section? It would help enhance the design.

@ambarmishraa
Copy link
Author

ok I will do that Asap.!

@ambarmishraa
Copy link
Author

ambarmishraa commented Oct 14, 2024

swaraj-das : You can now check the review section, its in the way you wished for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants