Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue :- #383 Solved :- Added Registration Pop up Succesfully #436

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

PrAyAg9
Copy link
Contributor

@PrAyAg9 PrAyAg9 commented Oct 15, 2024

Pull Request Format

PR Title - Added pop up Succesfully

Issue #383 : **[Feature] Adding a signup/login Popup on Home Page. ** solved

Type of PR

  • Add X in the box to specify the improvement type.
  • [] Bug fix
  • [X ] Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

This pull request aims to [briefly describe what the pull request does, e.g., "add a new feature," "fix a bug," "improve documentation," etc.].

Screenshots / Videos (if applicable)

Before:
image
This was before when you get to landing page L-

After:
image

  • [Describe the state after the changes, -- You can see that I have successfully implement a pop up which will provoke user to sign up with exciting deals for first time users]

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • [ X] I have tested the changes thoroughly before submitting this pull request.
  • [ X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [X ] I have commented my code, particularly in hard-to-understand areas.

Additional Context

I have seen it works fine, Check the design and it's working and inform if any inconsistencies found. Thank you.

Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 3:15pm

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit cbdcb9d
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/670e870cf91a870008c2e2eb
😎 Deploy Preview https://deploy-preview-436--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@swaraj-das
Copy link
Owner

swaraj-das commented Oct 15, 2024

@PrAyAg9 the code is good, and the popup looks great! However, there's a drawback. Please add a close button in the top-right corner to allow users to close the popup, as it currently does not close.

@PrAyAg9
Copy link
Contributor Author

PrAyAg9 commented Oct 15, 2024

@swaraj-das I've done it now if user clicks anywhere outside pop up it will close and that logo was meant to be a way to close as you mention and you can also close it by clicking on no thanks.

@PrAyAg9
Copy link
Contributor Author

PrAyAg9 commented Oct 15, 2024

@swaraj-das There was a conflict in my branch due to updation of some code in index.html, It was my first time to resolve a conflict.
So, Please check if everything working fine as I've already updated code of popup.js and then i tried to resolve conflict, Please check if everything's working fine and if something is wrong I'll raise a new pull request. Thank you

@swaraj-das swaraj-das merged commit e559fc0 into swaraj-das:main Oct 16, 2024
6 checks passed
@swaraj-das
Copy link
Owner

@swaraj-das There was a conflict in my branch due to updation of some code in index.html, It was my first time to resolve a conflict. So, Please check if everything working fine as I've already updated code of popup.js and then i tried to resolve conflict, Please check if everything's working fine and if something is wrong I'll raise a new pull request. Thank you

The code is well. I merged it.

@PrAyAg9 PrAyAg9 deleted the prayag_game branch October 16, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants