-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue :- #383 Solved :- Added Registration Pop up Succesfully #436
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for collect-your-gamingtools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@PrAyAg9 the code is good, and the popup looks great! However, there's a drawback. Please add a close button in the top-right corner to allow users to close the popup, as it currently does not close. |
@swaraj-das I've done it now if user clicks anywhere outside pop up it will close and that logo was meant to be a way to close as you mention and you can also close it by clicking on no thanks. |
@swaraj-das There was a conflict in my branch due to updation of some code in index.html, It was my first time to resolve a conflict. |
The code is well. I merged it. |
Pull Request Format
PR Title - Added pop up Succesfully
Issue #383 : **[Feature] Adding a signup/login Popup on Home Page. ** solved
Type of PR
Description
This pull request aims to [briefly describe what the pull request does, e.g., "add a new feature," "fix a bug," "improve documentation," etc.].
Screenshots / Videos (if applicable)
Before:
This was before when you get to landing page L-
After:
Checklist
Additional Context
I have seen it works fine, Check the design and it's working and inform if any inconsistencies found. Thank you.
Thank you for reviewing my pull request!