Navbar issue menulist #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Virenishere Please add some margin to the left of the logo for better look. |
|
sure let me change it as well |
|
@swaraj-das now please check the logo margin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navbar responsiveness, product title alignment, and reduced controller size for Add to Cart issue
Issue #30 : Navbar issue menulist solved
Pull Request Description
What I did:
Fixed the navbar: Resolved the issue where the navbar menu list was not displaying correctly on screen sizes smaller than 1024px.
Aligned the product title: Adjusted the title of the product to ensure proper alignment across different screen sizes for better readability and UI consistency.
Reduced controller size: Decreased the size of the controllers to fix the layout issue affecting the "Add to Cart" button, improving overall responsiveness and UX.
Why I did it:
The changes were necessary to improve the overall layout and usability on mobile devices and smaller screens.
The alignment and sizing issues were affecting the visual consistency of the product page and interfering with the Add to Cart functionality.
Testing and Validation:
Tested the changes on various screen sizes, including below 1024px.
Ensured that the navbar, product title alignment, and Add to Cart button display properly and are responsive across different devices.
Additional Notes:
Please verify the changes on smaller screen resolutions (e.g., mobile devices) to ensure full responsiveness.
No breaking changes were introduced.
Thank you for reviewing my pull request!