-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the darkmode text issue and also fixed the social sidebar of a… #501
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @Swati-in! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
✅ Deploy Preview for collect-your-gamingtools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
please label it hactoberfest-accepted and gssoc-ext |
Hi there! This issue is still open. We are looking forward to your response. |
Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨ |
Pull Request Format
PR Title: Fixed Darkmode Text Issue & Social Sidebar of About Us Page
Issue #414 : Closes
Type of PR
Description
-Modified Text Color for Dark Mode: Adjusted the text color to better complement the dark background (#493D3D). This ensures improved readability and a more polished UI for users in dark mode.
-Fixed Social Sidebar Logo Issue: Resolved the problem where some social media icons were not displaying correctly on the "About Us" page. All icons now render consistently across all pages.
Changes Made:
-Updated CSS for text color to suit dark mode.
-Fixed the missing social media icons in the sidebar by correcting the import and icon rendering issues.
Screenshots / Videos (if applicable)
Before:
After:
Checklist
Additional Context
The missing social media icons were due to inconsistencies in the Font Awesome imports and icon class names. After reviewing the imports and updating the incorrect icon classes, I ensured that all social media icons (including Twitter and YouTube) are now displaying correctly.
Thank you for reviewing my pull request!