Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the darkmode text issue and also fixed the social sidebar of a… #501

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

Swati-in
Copy link
Contributor

Pull Request Format

PR Title: Fixed Darkmode Text Issue & Social Sidebar of About Us Page

Issue #414 : Closes

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

-Modified Text Color for Dark Mode: Adjusted the text color to better complement the dark background (#493D3D). This ensures improved readability and a more polished UI for users in dark mode.

-Fixed Social Sidebar Logo Issue: Resolved the problem where some social media icons were not displaying correctly on the "About Us" page. All icons now render consistently across all pages.

Changes Made:

-Updated CSS for text color to suit dark mode.
-Fixed the missing social media icons in the sidebar by correcting the import and icon rendering issues.

Screenshots / Videos (if applicable)

Before:
image

After:
image

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

The missing social media icons were due to inconsistencies in the Font Awesome imports and icon class names. After reviewing the imports and updating the incorrect icon classes, I ensured that all social media icons (including Twitter and YouTube) are now displaying correctly.

Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:35am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Swati-in! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 3f87502
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/6710b04386503a0008e5a4ef
😎 Deploy Preview https://deploy-preview-501--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Swati-in
Copy link
Contributor Author

please label it hactoberfest-accepted and gssoc-ext

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@swaraj-das swaraj-das merged commit 6ca0200 into swaraj-das:main Oct 17, 2024
6 checks passed
Copy link

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants