-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google Authentication to the Application #340 #504
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @simmi-verma! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
✅ Deploy Preview for collect-your-gamingtools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi there! This issue is still open. We are looking forward to your response. |
I have added Google authentication |
Demo vedio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me.. but I want a demo vedio
Thank you for your feedback! I will create a demo video showcasing the Google authentication implementation. Please let me know if there are specific features or steps you’d like me to highlight. |
No |
auth.js.-.gssoc.-.Visual.Studio.Code.2024-10-17.20-42-19.mp4added.login.functionality.mp4i have added the login functionality (through the google ) to the website i have shown demo in this video |
@simmi-verma can you please change the login to log out if the user login already |
You don't required to write the functionality of logout just change the login to logout |
Ok I will update it soon |
I have changed 'Login' to 'Logout' when clicking on 'login in with Google'. |
@simmi-verma please give a vedio |
bandicam.2024-10-18.20-52-41-320.mp4 |
Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨ |
This PR updates the Firebase configuration by replacing hardcoded credentials with environment variables to enhance security. Sensitive keys such as apiKey, authDomain, and others are now stored in environment variables, ensuring that they are not exposed in the codebase. This also improves flexibility for different environments (e.g., development, production) by allowing the configuration to be dynamically set based on environment-specific values.