Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Authentication to the Application #340 #504

Merged
merged 4 commits into from
Oct 20, 2024

Conversation

simmi-verma
Copy link
Contributor

This PR updates the Firebase configuration by replacing hardcoded credentials with environment variables to enhance security. Sensitive keys such as apiKey, authDomain, and others are now stored in environment variables, ensuring that they are not exposed in the codebase. This also improves flexibility for different environments (e.g., development, production) by allowing the configuration to be dynamically set based on environment-specific values.

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 0:20am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @simmi-verma! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 9f11efc
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/6714f59bfddfc20008a1502e
😎 Deploy Preview https://deploy-preview-504--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@simmi-verma
Copy link
Contributor Author

I have added Google authentication

@AnitSarkar123
Copy link
Collaborator

I have added Google authentication

Demo vedio

Copy link
Collaborator

@AnitSarkar123 AnitSarkar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.. but I want a demo vedio

@simmi-verma
Copy link
Contributor Author

simmi-verma commented Oct 17, 2024

Thank you for your feedback! I will create a demo video showcasing the Google authentication implementation. Please let me know if there are specific features or steps you’d like me to highlight.

@AnitSarkar123
Copy link
Collaborator

Thank you for your feedback! I will create a demo video showcasing the Google authentication implementation. Please let me know if there are specific features or steps you’d like me to highlight.

No

@simmi-verma
Copy link
Contributor Author

simmi-verma commented Oct 18, 2024

auth.js.-.gssoc.-.Visual.Studio.Code.2024-10-17.20-42-19.mp4
added.login.functionality.mp4

i have added the login functionality (through the google ) to the website i have shown demo in this video

@AnitSarkar123
Copy link
Collaborator

@simmi-verma can you please change the login to log out if the user login already

@AnitSarkar123
Copy link
Collaborator

@simmi-verma can you please change the login to log out if the user login already

You don't required to write the functionality of logout just change the login to logout

@simmi-verma
Copy link
Contributor Author

simmi-verma commented Oct 18, 2024

Ok I will update it soon

@simmi-verma
Copy link
Contributor Author

simmi-verma commented Oct 18, 2024

I have changed 'Login' to 'Logout' when clicking on 'login in with Google'.

@AnitSarkar123
Copy link
Collaborator

@simmi-verma please give a vedio

@simmi-verma
Copy link
Contributor Author

bandicam.2024-10-18.20-52-41-320.mp4

@swaraj-das swaraj-das merged commit a9be300 into swaraj-das:main Oct 20, 2024
5 checks passed
Copy link

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants