Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Cart Button #529 #575

Closed

Conversation

Ashish-Patnaik
Copy link
Contributor

Pull Request Format

Fixed Cart Button in About-Us Page

Issue #529 : The Cart icon is not visible in About Us Page solved

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix

Description

This pull request aims to fix the Cart icon which is not visible in the About-Page but now it fixed and designed in a way the repo owners asked

Screenshots / Videos (if applicable)

Before:
1

After:
11

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 8:18am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Ashish-Patnaik! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 09eb67f
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/6714bcd8cae7a40009abcd8d
😎 Deploy Preview https://deploy-preview-575--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ashish-Patnaik
Copy link
Contributor Author

Kindly merge this PR @swaraj-das as I have done as you asked and I am very grateful for this contribution

@swaraj-das
Copy link
Owner

@Ashish-Patnaik You could not make it as the home page, if you can, then do it or leave it. I will do.

@Ashish-Patnaik
Copy link
Contributor Author

Ashish-Patnaik commented Oct 20, 2024

@swaraj-das but I have made the cart icon exactly like the home page as you can see in the screenshots and already made a PR what's the problem if you can tell me I can correct

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@swaraj-das
Copy link
Owner

@swaraj-das but I have made the cart icon exactly like the home page as you can see in the screenshots and already made a PR what's the problem if you can tell me I can correct

You can check the code of index.html..that cart button I made inside the button tag, but you made inside list.

@Ashish-Patnaik
Copy link
Contributor Author

Ok I will correct as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants