Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Navbar Design #586

Closed

Conversation

khurshed07
Copy link

Hi @swaraj-das

Pull Request Format

PR Title

Modify Navbar Design : Revamp Your Website: Stylish Navbar Menu for Contributing to an Open-Source Project for a Sleek and Modern Design Issue #456

Issue #456 : Revamp Your Website: Stylish Navbar Menu for Contributing to an Open-Source Project for a Sleek and Modern Design solved

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): Modify the Navbar Design Menu and give it proper spacing to enhance its visual appeal and improve the overall user experience

Description

This pull request aims to [Revamp Your Website: Stylish Navbar Menu for Contributing to an Open-Source Project for a Sleek and Modern Design].

Screenshots / Videos (if applicable)

Before Changes:

Screenshot 2024-10-19 164057
Screenshot 2024-10-19 164109

After Changes:

Light Mode

Screenshot 2024-10-19 163426
Screenshot 2024-10-19 163432
Screenshot 2024-10-19 163441
Screenshot 2024-10-19 163447
Screenshot 2024-10-19 163454
Screenshot 2024-10-19 163500
Screenshot 2024-10-19 163506

Dark Mode

Screenshot 2024-10-19 163514
Screenshot 2024-10-19 163519
Screenshot 2024-10-19 163526
Screenshot 2024-10-19 163532
Screenshot 2024-10-19 163540
Screenshot 2024-10-19 163548
Screenshot 2024-10-19 163556

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Hi @swaraj-das
I recently updated the navbar menu for your project to make it more attractive and user-friendly. Enhance readability, improve navigation, and give your site a visually appealing touch that stands out with these simple yet impactful design updates. I've attached screenshots of the changes and contribute to this enhancement to improve the overall design.

Thank you for reviewing my pull request!
I'm looking forward to hearing feedback from you!
Best regards,

Issue #456

@khurshed07
https://github.com/khurshed07

Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 11:21am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @khurshed07! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 9ede6b2
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/6713963ada3be00008d8f4a5
😎 Deploy Preview https://deploy-preview-586--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@swaraj-das
Copy link
Owner

swaraj-das commented Oct 19, 2024

@khurshed07 The hover effects you added are not up to the mark.

I didn’t assign you to this issue, yet you submitted a PR. This isn't acceptable. Reviewing PRs takes time, and your unnecessary submission wasted mine.

@swaraj-das swaraj-das closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants