Added Deals in Hero Section as Slider #635
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @Nitheesha33! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
✅ Deploy Preview for collect-your-gamingtools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@swaraj-das the only issue is with a PR without the label. Other than that, my PR is perfectly able to deploy. I request you to look into this asap. |
|
Hi there! This issue is still open. We are looking forward to your response. |
1 similar comment
|
Hi there! This issue is still open. We are looking forward to your response. |
| @@ -0,0 +1,43 @@ | |||
| let slideIndex = 1; | |||
There was a problem hiding this comment.
Do not create a separate 'hero-slider' folder. Instead, please add the JavaScript for the hero slider directly into the existing script.js file.
| </div> | ||
| </div> | ||
| </li> | ||
|
|
||
| <li class="login"><a href="login/login.html">Login</a></li> |
There was a problem hiding this comment.
Add two buttons to the slider that allow users to navigate the images left (previous) and right (next) within the slider.
| @@ -52,6 +52,17 @@ | |||
| <li><a href="#keyboard">Gaming Keyboard</a></li> | |||
| <li><a href="#others">Others</a></li> | |||
|
|
|||
| <!--adding short search bar--> | |||
There was a problem hiding this comment.
You can position the search bar at the bottom of the navbar to enhance the user experience.
|
@swaraj-das Sure, I will make these changes and get back to you. In the meantime, I kindly request you to add an appropriate level label to the issue to pass all the checks when submitting my PR. |
|
Hi there! This issue is still open. We are looking forward to your response. |
Added Delas in the Hero Section as a slider
Issue #535 : Added Deals in the hero section as a slider
Type of PR
Description
This pull request aims to add a new slider in the hero section of the website to showcase ongoing and upcoming deals, as well as new arrivals. The slider enhances the user experience by allowing customers to quickly view the latest offers and arrivals in a visually appealing manner.
Screenshots / Videos (if applicable)
Before:
before-slides.mp4
After:
after-slides.mp4
Checklist
Additional Context
I have implemented three slides in total: one for ongoing deals, one for upcoming deals, and another for new arrivals. The challenge was to ensure smooth transitions between the slides while maintaining performance. After considering different design options, I decided to prioritize a clean, minimalist layout for better readability and engagement.
Thank you for reviewing my pull request!
@swaraj-das Please label my issue with the appropriate level and then merge my pr