Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Theme toggle button to About page #637

Closed
wants to merge 2 commits into from

Conversation

AnushkaChouhan25
Copy link

@AnushkaChouhan25 AnushkaChouhan25 commented Oct 21, 2024

Pull Request Format

PR Title

Issue #620 : Add Theme toggle button to About page

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

I added a theme toggle button to the About Us page, which was lacking. This would allow users to switch between light and dark modes easily on the About page.

Screenshots / Videos (if applicable)

Before:
image

After:
image

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented on my code, particularly in hard-to-understand areas.

Additional Context

I have also updated the Add to Cart button background to look similar to other pages.

Thank you for reviewing my pull request!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @AnushkaChouhan25! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 7:01pm

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 6c78053
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/6716a4fec8fe5800084eb14e
😎 Deploy Preview https://deploy-preview-637--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

1 similar comment
Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

<li><label class="switch">
<input type="checkbox" id="theme-toggle" onchange="toggleTheme()">
<span class="slider"></span>
</label></li>
<!-- Inside the navbar ul -->

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changes did you even make? Why would you submit a pull request without any single effort?

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@github-actions github-actions bot added the Stale label Nov 1, 2024
@github-actions github-actions bot closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants