Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eye icon added #723

Merged
merged 1 commit into from
Nov 6, 2024
Merged

eye icon added #723

merged 1 commit into from
Nov 6, 2024

Conversation

PATILYASHH
Copy link
Contributor

Pull Request Format

PR Title

Issue #709 : Add "Eye" Icon to Toggle Password Visibility in Password Input Field solved

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

In this PR I added Eye Icons to login and sing up page for viewing passwords while writing it

Screenshots / Videos (if applicable)

Before:

  • Login Page
    image

  • Signup Page

image

After:

  • Login page
    image

  • Signup Page
    image

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 5:22am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @PATILYASHH! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit dedf6d3
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/67231405fd2c050008004c44
😎 Deploy Preview https://deploy-preview-723--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PATILYASHH
Copy link
Contributor Author

@swaraj-das Please review the PR

Copy link

github-actions bot commented Nov 1, 2024

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

1 similar comment
Copy link

github-actions bot commented Nov 2, 2024

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@PATILYASHH
Copy link
Contributor Author

Sir please review the PR

Copy link

github-actions bot commented Nov 3, 2024

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

3 similar comments
Copy link

github-actions bot commented Nov 4, 2024

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

github-actions bot commented Nov 5, 2024

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

github-actions bot commented Nov 6, 2024

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@swaraj-das swaraj-das merged commit fd2ac2c into swaraj-das:main Nov 6, 2024
6 of 7 checks passed
Copy link

github-actions bot commented Nov 6, 2024

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants